Include process names in message before installing package. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mast-eu
approved these changes
Dec 9, 2020
| "Plugin Manager", | ||
| "Plugin Manager is going to write to files that are holded by other executables. " + Environment.NewLine + | ||
| "Do you want to kill all instances of these applications?" | ||
| $"Plugin Manager will be writing to files that are currently in use.\r\n\r\nDo you want to stop {processNames}?" |
Member
There was a problem hiding this comment.
Suggested change
| $"Plugin Manager will be writing to files that are currently in use.\r\n\r\nDo you want to stop {processNames}?" | |
| $"Plugin Manager will be writing to files that are currently in use.\r\n\r\nDo you want to stop all instances of {processNames}?" | |
This is really just a detail and I have no strong feelings about it. At the end I accept both forms, with and without this suggestion.
Member
Author
There was a problem hiding this comment.
I have no option. I'm not good at user texts, as I tend to put there too much information.
Think it's @RussKie's call 😎
Member
There was a problem hiding this comment.
I suppose if there's only a single instance of an app, than it is the first message. Else the second ;))
RussKie
reviewed
Dec 10, 2020
Member
RussKie
left a comment
RussKie
left a comment
There was a problem hiding this comment.
I also suggest changing the messagebox's icon to either question or warning.
LGTM
Member
Author
|
Message now contains or don't information about instances based on process count to kill. |
RussKie
approved these changes
Dec 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51, an alternative to #52.